You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I love how robust the reconnection is, however if connections fail repeatedly, then the default of attempting every 0.5 seconds is going to hammer a struggling server.
If the reason that the connection is failing is a server in trouble, then this potentially adds something close to a denial of service attack on top of whatever problem exists...
Standard practice would be an exponential fallback - so, waiting (twice?, 1.5x?) as long between each reconnection attempt.
Perhaps to a maximum of a 60 second delay between checks...
I'm happy to have a go if you'd accept a pull request...
The text was updated successfully, but these errors were encountered:
I'll be glad to accept your pull request, but please make the reconnect parameter data type enum instead of boolean. Let the enum contain three cases: none, standard, and your reconnect case
This library was made very quickly for my project, it still works there. I want to say that there was no goal to make a library. I realized that it might be useful to others, so I made it public. This means that I wrote the code a long time ago and there may be inaccuracies. Just make your code work, you can rewrite my watcher if needed
I love how robust the reconnection is, however if connections fail repeatedly, then the default of attempting every 0.5 seconds is going to hammer a struggling server.
If the reason that the connection is failing is a server in trouble, then this potentially adds something close to a denial of service attack on top of whatever problem exists...
Standard practice would be an exponential fallback - so, waiting (twice?, 1.5x?) as long between each reconnection attempt.
Perhaps to a maximum of a 60 second delay between checks...
I'm happy to have a go if you'd accept a pull request...
The text was updated successfully, but these errors were encountered: