Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requirements.txt needs python-slugify #185

Open
aryamanarora opened this issue May 28, 2020 · 9 comments
Open

requirements.txt needs python-slugify #185

aryamanarora opened this issue May 28, 2020 · 9 comments

Comments

@aryamanarora
Copy link
Member

Needs python-slugify as a dependency. Besides that, setting it up locally had no issues.

@aryamanarora aryamanarora changed the title requirements.txt requirements.txt needs python-slugify May 28, 2020
@nschneid
Copy link
Contributor

Where is it used?

@aryamanarora
Copy link
Member Author

ah so the real issue is that the dependencies for nert-nlp/django-categories should all be included in this repo too

@nschneid
Copy link
Contributor

@lgessler Do you recall why we have a fork of django-categories?

@lgessler
Copy link
Contributor

lgessler commented May 31, 2020

Basically, while we were working on #155, we found that django-categories's source code was directly committed to the repo at wiki/plugins/categories (cf. e.g. this commit), with custom changes we'd applied directly to this directory.

We decided that the cleanest thing to do was to fork django-categories, apply our changes downstream, and depend on it via a git submodule and a symlink. I can expand if you want.

Now that I'm thinking about it again though, a cleaner solution might be to get rid of the submodule and symlink and put git+git://github.com/nert-nlp/django-categories.git@master in this repo's requirements.txt. That should take care of the slugify dependency automatically.

@nschneid
Copy link
Contributor

Sounds good to me

@lgessler
Copy link
Contributor

BTW, if the django-categories dependency moves to requirements.txt, all references (in code and configuration) to wiki.plugins.categories will need to refer to categories instead. I don't think any other changes should be necessary.

@ablodge
Copy link
Contributor

ablodge commented Jun 12, 2020

@lgessler How should the reference to wiki.plugins.categories.apps.CategoriesConfig be handled? It doesn't look like there is any reference to this in the django-categories repo. It gives me the following error:

django.core.exceptions.ImproperlyConfigured: Cannot import 'wiki.plugins.categories'. Check that 'categories.apps.CategoriesConfig.name' is correct

@lgessler
Copy link
Contributor

I think what needs to happen is that CategoriesConfig.name needs to be assigned to just categories

@ablodge
Copy link
Contributor

ablodge commented Jun 15, 2020

Can you merge nert-nlp/django-categories#1 ?

ablodge added a commit that referenced this issue Jun 16, 2020
nschneid added a commit that referenced this issue Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants