Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encapsulate custom code in article.py #148

Open
ablodge opened this issue Sep 25, 2018 · 1 comment
Open

Encapsulate custom code in article.py #148

ablodge opened this issue Sep 25, 2018 · 1 comment
Labels
priority

Comments

@ablodge
Copy link
Contributor

ablodge commented Sep 25, 2018

This is a subtask of #45. The main class in wiki\views\article.py has some customizations that need to be separated into another file.

What about wiki/views/article.py? I think we customized that too. But it would be better to move the customization to a MetadataArticleView subclass in wiki.plugins.metadata.views that is substituted for the regular ArticleView by wiki.plugins.metadata.urls.XpositionURLPatterns.
@nschneid
Copy link
Contributor

@lgessler Can we factor out our changes to https://github.com/nert-nlp/Xposition/blob/master/src/wiki/views/article.py and put them under the metadata plugin (or xposition site directory)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nschneid @ablodge