Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate replacing sender.go with conn.go #11

Open
soygul opened this issue Dec 29, 2015 · 0 comments
Open

Evaluate replacing sender.go with conn.go #11

soygul opened this issue Dec 29, 2015 · 0 comments

Comments

@soygul
Copy link
Member

soygul commented Dec 29, 2015

So we can have higher level protocol stuff (marshaling, unmarshaling etc.) in one place. Currently serialization is in Sender and deserialization is in Middleware.

We can have a jsonrpc.Conn which implements neptulon.Conn and feed it to the neptulon.Client which is used by the jsonrpc.Client.

On the other hand, we can rename neptulon.Conn and jsonrpc.Sender both to Protocol as they are nothing more than implementations of the underlying communication protocols.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant