[1.21] Add ICustomHolderSet support for StreamCodec created from ByteBufCodecs#holderSet

[RaymondBlaze]

Fixes #981.
This PR adds support for ICustomHolderSet for StreamCodec created from ByteBufCodecs#holderSet.
Introduced tests for HolderSet related Codec and StreamCodec.

Changes

• HolderSetType is no longer a functional interface due to the newly introduced makeStreamCodec method.
• NeoForgeRegistries.HOLDER_SET_TYPES is now synced as ByteBufCodecs#holderSet's implementation uses raw id for HolderSetType.

Implementation Note

• ByteBufCodecs#holderSet's implementation made use of the vanilla unused negative VarInt values(starting from -1) as HolderSetType ids to support ICustomHolderSet.
• StreamCodec instance for ICustomHolderSet created from HolderSetType#makeStreamCodec method are lazily computed and cached in the StreamCodec instance created from ByteBufCodecs#holderSet for better performance, which is a bit different from the implementation of HolderSetCodec which doesn't cache the created Codec from HolderSetType#makeCodec.

[CLAassistant]

All committers have signed the CLA.

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

[XFactHD]

This approach will blow up on a NeoForge -> Vanilla connection because vanilla will try to handle the custom holder sets as HolderSet.Directs: The decoder will first attempt to create an ArrayList with an initial size of Math.min(varInt, 65536) which will throw an IllegalArgumentException due to a negative value. If the decoder were to get past this list issue, then the data emitted by the specific implementations will either misbehave or crash when the decoder attempts to read the first entry: The AndHolderSet and OrHolderSet write a List<HolderSet> (would attempt to read the list size as the first Holder or part thereof), the NotHolderSet writes a nested HolderSet (would attempt to read the direct holder size or named holder set marker [the var-int being repurposed in this PR] as the first Holder or part thereof) and the AnyHolderSet writes nothing (would attempt to read past the buffer's end or into data that should be handled by another decoder).

I currently have no idea how this could be solved in a way that is vanilla-compatible. While it's definitely not great in terms of packet size (especially for the AnyHolderSet), I would consider it safer to keep the fallback to HolderSet.Direct for custom holder sets for the time being as it retains full vanilla network compatibility.

[lukebemish]

Beyond that, wouldn't making NeoForgeRegistries.HOLDER_SET_TYPES synced blow up those connections even earlier? Also not sure what a sensible solution here is.

[XFactHD]

No, marking a registry as synced does not blow up the connection as registry sync only happens on NF<->NF connections

[RaymondBlaze]

This approach will blow up on a NeoForge -> Vanilla connection

This only happens if a ICustomHolderSet is used, I would argue the behavior of "sending ICustomHolderSet to Vanilla" itself should not expect any success.
Note that the patched StreamCodec for Ingredient is already using the same implementation that make use of illegal list size VarInt, and the above argue also applies to it.

[RaymondBlaze]

Changed target to 1.21.x, added checks for ConnectionType and vanilla connection should be happy with ICustomHolderSets now.

[neoforged-compatibility-checks]

@RaymondBlaze, this PR introduces breaking changes.
Fortunately, this project is currently accepting breaking changes, but if they are not intentional, please revert them.
Last checked commit: 47f81c67ba3b01598273c77e1f3aafafc464d9f2.

Compatibility checks

neoforge (:neoforge)

• net/neoforged/neoforge/registries/holdersets/OrHolderSet
  • codec(Lnet/minecraft/resources/ResourceKey;Lcom/mojang/serialization/Codec;Z)Lcom/mojang/serialization/MapCodec;: ❗ API method was removed
• net/neoforged/neoforge/registries/holdersets/NotHolderSet
  • codec(Lnet/minecraft/resources/ResourceKey;Lcom/mojang/serialization/Codec;Z)Lcom/mojang/serialization/MapCodec;: ❗ API method was removed
• net/neoforged/neoforge/registries/holdersets/HolderSetType
  • makeStreamCodec(Lnet/minecraft/resources/ResourceKey;)Lnet/minecraft/network/codec/StreamCodec;: ❗ Method was made abstract
• net/neoforged/neoforge/registries/holdersets/AnyHolderSet
  • codec(Lnet/minecraft/resources/ResourceKey;Lcom/mojang/serialization/Codec;Z)Lcom/mojang/serialization/MapCodec;: ❗ API method was removed
• net/neoforged/neoforge/registries/holdersets/AndHolderSet
  • codec(Lnet/minecraft/resources/ResourceKey;Lcom/mojang/serialization/Codec;Z)Lcom/mojang/serialization/MapCodec;: ❗ API method was removed

[Shadows-of-Fire]

Impl looks fine. Couple changes needed for sanity, then should be good to go.