Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw only when passed clientside level #1707

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

TelepathicGrunt
Copy link
Contributor

Modders can implement fake levels that are server side with a chunk cache. We were throwing on these when our exception specifically stated client side issue. So the exception was untrue. The fix is restrict our check to make sure the thrown exception is correct

Closes #1669

@TelepathicGrunt TelepathicGrunt added bug A bug or error 1.21.3 Targeted at Minecraft 1.21.3 labels Nov 26, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Nov 26, 2024

  • Publish PR to GitHub Packages

Last commit published: 0ba68b162f9751d6c847ddc556788594ecc6d622.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1707' // https://github.com/neoforged/NeoForge/pull/1707
        url 'https://prmaven.neoforged.net/NeoForge/pr1707'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1707.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1707
cd NeoForge-pr1707
curl -L https://prmaven.neoforged.net/NeoForge/pr1707/net/neoforged/neoforge/21.3.43-beta-pr-1707-PacketDistributorFIx/mdk-pr1707.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@marchermans marchermans merged commit 979d8e5 into neoforged:1.21.x Nov 27, 2024
7 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.3.44-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.3 Targeted at Minecraft 1.21.3 bug A bug or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PacketDistributor crashes when given a custom Level implementation
2 participants