Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action updates #1172

Merged
merged 21 commits into from
Jun 24, 2024
Merged

Action updates #1172

merged 21 commits into from
Jun 24, 2024

Conversation

Matyrobbrt
Copy link
Member

@Matyrobbrt Matyrobbrt commented Jun 23, 2024

  • add JarCompatibilityChecker
  • add a check to prevent datagen'd files from not being generated
  • switch to the setup-gradle action
  • add a wrapper validation action in the pr test pipeline

@Matyrobbrt Matyrobbrt added 1.21 Targeted at Minecraft 1.21 ci/build Related to continuous integration/build system labels Jun 23, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jun 23, 2024

  • Publish PR to GitHub Packages

Last commit published: 3eeba8c1cd57777c002f2b8426a400646f4ffbbd.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1172' // https://github.com/neoforged/NeoForge/pull/1172
        url 'https://prmaven.neoforged.net/NeoForge/pr1172'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1172.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1172
cd NeoForge-pr1172
curl -L https://prmaven.neoforged.net/NeoForge/pr1172/net/neoforged/neoforge/21.0.53-beta-pr-1172-jcc/mdk-pr1172.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@Matyrobbrt Matyrobbrt marked this pull request as ready for review June 24, 2024 13:13
build.gradle Show resolved Hide resolved
@shartte
Copy link
Contributor

shartte commented Jun 24, 2024

"But my workflow relied on the brush being a bow!!!!!!!!"

@Matyrobbrt
Copy link
Member Author

It's a feature, not a bug :shipit:.

@Matyrobbrt Matyrobbrt merged commit 238c02a into neoforged:1.21.x Jun 24, 2024
5 checks passed
@Matyrobbrt Matyrobbrt deleted the jcc branch June 24, 2024 14:49
Matyrobbrt added a commit to Matyrobbrt/NeoForge that referenced this pull request Aug 27, 2024
Adds JCC and check local changes so that 1.20.x PRs can be merged. Additionally, updates to setup-gradle@v4 and the new custom action for setting up Java.
sciwhiz12 pushed a commit that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21 Targeted at Minecraft 1.21 ci/build Related to continuous integration/build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants