Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21] Fix transforms for modded ItemDisplayContexts being ignored #1164

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

XFactHD
Copy link
Member

@XFactHD XFactHD commented Jun 22, 2024

This PR fixes transforms for modded ItemDisplayContexts specified in item model JSONs being ignored. The patch for this was lost in the 1.20.2 update. The fix is intentionally different from the old implementation in 1.20.1 as that implementation completely ignored the optional fallback type that can be specified for modded ItemDisplayContexts.

Fixes #1159

@XFactHD XFactHD added bug A bug or error rendering Related to rendering regression Worked previously but doesn't anymore 1.21 Targeted at Minecraft 1.21 labels Jun 22, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jun 22, 2024

  • Publish PR to GitHub Packages

Last commit published: 3df1b61ff71270f10910a0f41983742fb9159975.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1164' // https://github.com/neoforged/NeoForge/pull/1164
        url 'https://prmaven.neoforged.net/NeoForge/pr1164'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1164.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1164
cd NeoForge-pr1164
curl -L https://prmaven.neoforged.net/NeoForge/pr1164/net/neoforged/neoforge/21.0.35-beta-pr-1164-fix_modded_item_transforms/mdk-pr1164.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@Matyrobbrt Matyrobbrt merged commit 869077c into neoforged:1.21.x Jun 24, 2024
6 checks passed
@XFactHD XFactHD deleted the fix_modded_item_transforms branch June 24, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21 Targeted at Minecraft 1.21 bug A bug or error regression Worked previously but doesn't anymore rendering Related to rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom ItemDisplayContext enum extensions not supported, despite implementing IExtensibleEnum
2 participants