Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpawnPlacementRegisterEvent -> RegisterSpawnPlacementsEvent #1154

Merged
merged 7 commits into from
Jul 7, 2024
Merged

SpawnPlacementRegisterEvent -> RegisterSpawnPlacementsEvent #1154

merged 7 commits into from
Jul 7, 2024

Conversation

Spinoscythe
Copy link
Contributor

Who doesn't like consistency?

@Spinoscythe Spinoscythe marked this pull request as ready for review June 20, 2024 21:14
@neoforged-pr-publishing
Copy link

  • Publish PR to GitHub Packages

@neoforged-compatibility-checks
Copy link

neoforged-compatibility-checks bot commented Jun 25, 2024 •
edited
Loading

@Spinoscythe, this PR introduces breaking changes.
Fortunately, this project is currently accepting breaking changes, but if they are not intentional, please revert them.
Last checked commit: 8e6b7cfb59814950b92f99e78cb3429cd8839553.

neoforge (:neoforge)

  • net/neoforged/neoforge/event/entity/SpawnPlacementRegisterEvent
    • ❗ API class no longer exists
  • net/neoforged/neoforge/event/entity/SpawnPlacementRegisterEvent$MergedSpawnPredicate
    • ❗ API class no longer exists
  • net/neoforged/neoforge/event/entity/SpawnPlacementRegisterEvent$Operation
    • ❗ API class no longer exists

@sciwhiz12 sciwhiz12 added cleanup Change that isn't an enhancement or a bug fix breaking change Breaks binary compatibility 1.21 Targeted at Minecraft 1.21 labels Jul 3, 2024
@TelepathicGrunt TelepathicGrunt dismissed sciwhiz12’s stale review July 7, 2024 12:53

Sci's suggestions were implemented

@TelepathicGrunt TelepathicGrunt merged commit 1ac954e into neoforged:1.21.x Jul 7, 2024
6 checks passed
@Spinoscythe Spinoscythe deleted the enhancement/spawnplacement-event branch July 7, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TelepathicGrunt TelepathicGrunt TelepathicGrunt approved these changes

@Shadows-of-Fire Shadows-of-Fire Awaiting requested review from Shadows-of-Fire

@sciwhiz12 sciwhiz12 Awaiting requested review from sciwhiz12

Assignees
No one assigned
Labels
1.21 Targeted at Minecraft 1.21 breaking change Breaks binary compatibility cleanup Change that isn't an enhancement or a bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Spinoscythe @Shadows-of-Fire @sciwhiz12 @TelepathicGrunt