-
-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convention tag requests #894
Comments
Simple, no one asked for one and I’m tired. Make a list of the grouping tags for vanilla dyed stuff and make a fabric issue report linking this too for coordination so someone can make prs |
Fabric has a shulker box item tag. Vanilla has a block item tag for shulker boxes |
Thoughts for a |
Here are some suggestions below I have for custom tags via my datapack mod, and I don't know if they are already included or not or if they could be considered. Item tags for |
Nvm no cheeses 😔 |
@ModernGamingWorld Just fyi, there is already a chains tag I dont think a tanks tags or jars tag will succeed as those sound ambiguous. But can you explain your exact use cases for those two? If it is about detecting functionality, like a working fluid tank, not sure c:tanks is the way to go with that. And would jar be for storage containers or for decorative jars? If you're trying to detect storage, a tag may be too ambiguous and cause you to get decorative jars instead. |
so @TelepathicGrunt my tag suggestions are based on this (https://github.com/AzureDoom/Modern-s-Monumental-Recipe/tree/1.19.2/src/main/resources/data/modernrecipes/tags/items) and what I did in my datapack. I was only suggesting them to maybe make things easier whenever it came to modpack creation. |
I agree with the others, these tags sound too vague to be useful. While it might make your modpack creation easier, I doubt it will help others if they don't understand why these tags are useful. You will have more success in this suggestion if you list each tag you want added and exactly what it is meant to do, don't just link your datapack and say "add this" |
I could see a case for cloth as some modders may want that as a repair too for clothes tbh. But that’s the only one I see some general possible use case for |
Closed as of #1030 |
Convo about the new tags should move here for easier discussion #1146 |
Note
Any requests for a new tag under the
c:
namespace should also be mirrored to the https://github.com/FabricMC/fabric repository.No change to the tags will be entertained that is not brought up for discussion on Fabric's side.
Neither will a PR to these tags be merged unless both NeoForge and Fabric have approved the PR with the same tag(s), the same contents, and the same definition of what the tag(s) contains.
~ @sciwhiz12
Why is there no shulker box tag? 😭 @TelepathicGrunt
The text was updated successfully, but these errors were encountered: