-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[1.21.3] Add condition to validate feature flags enabled state #1712
Conversation
Last commit published: 6c6e026a039be0f4ec5dd29f32d84936f85858f7. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1712' // https://github.com/neoforged/NeoForge/pull/1712
url 'https://prmaven.neoforged.net/NeoForge/pr1712'
content {
includeModule('net.neoforged', 'testframework')
includeModule('net.neoforged', 'neoforge')
}
}
} MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1712
cd NeoForge-pr1712
curl -L https://prmaven.neoforged.net/NeoForge/pr1712/net/neoforged/neoforge/21.3.53-beta-pr-1712-pr-flag-condition/mdk-pr1712.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip To test a production environment, you can download the installer from here. |
src/main/java/net/neoforged/neoforge/common/conditions/FlagCondition.java
Outdated
Show resolved
Hide resolved
src/main/java/net/neoforged/neoforge/common/conditions/FlagCondition.java
Outdated
Show resolved
Hide resolved
🚀 This PR has been released as NeoForge version |
Modders who maintain multi-jar mods, that being mods whose feature set is split across multiple jars, may want a single flag in their common jar which toggles features across all of their mod jars. Due to the nature of how feature packs work and are enabled, this is not possible.
While you can have multiple packs which all enable the same flag, they will all display as individual selections in the "experiments" screen, when the intention is to have 1 toggle for all these packs.
To work around that, modders can make use of the newly added condition in this PR, which takes in a set of feature flags and whether to validate for them being enabled or disabled to conditionally load their desired elements without needing to be in the same feature pack.