Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.3] Custom name tag component set in RenderNameTagEvent$CanRender is ignored #1667

Closed
Fuzss opened this issue Nov 5, 2024 · 1 comment · Fixed by #1675
Closed

[1.21.3] Custom name tag component set in RenderNameTagEvent$CanRender is ignored #1667

Fuzss opened this issue Nov 5, 2024 · 1 comment · Fixed by #1675
Labels
1.21.3 Targeted at Minecraft 1.21.3 bug A bug or error regression Worked previously but doesn't anymore rendering Related to rendering

Comments

@Fuzss
Copy link

Fuzss commented Nov 5, 2024

Minecraft Version: 1.21.3

NeoForge Version: 21.3.4-beta

The component in EntityRenderState#nameTag is always set from EntityRenderer::getNameTag, RenderNameTagEvent$CanRender::getContent is never used.

Also on a side note it is no longer possible to render name tags for entities more than 64 blocks away due to RenderNameTagEvent$CanRender only being called when entity.distanceToCameraSq < 4096.0, which wasn't the case before 1.21.2.
Before only the name tag renderer would check the distance, and by cancelling the event and rendering the name tag yourself it was possible to bypass the distance check.

@Fuzss Fuzss added the triage Needs triaging and confirmation label Nov 5, 2024
@XFactHD XFactHD added bug A bug or error rendering Related to rendering regression Worked previously but doesn't anymore 1.21.3 Targeted at Minecraft 1.21.3 and removed triage Needs triaging and confirmation labels Nov 9, 2024
@neoforged-releases
Copy link

🚀 This issue has been resolved in NeoForge version 21.3.52-beta, as part of #1675.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.3 Targeted at Minecraft 1.21.3 bug A bug or error regression Worked previously but doesn't anymore rendering Related to rendering
Projects
None yet
2 participants