Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.3] Show a range's default value in config file #1652

Merged

Conversation

TelepathicGrunt
Copy link
Contributor

Closes #1643

@TelepathicGrunt TelepathicGrunt added enhancement New (or improvement to existing) feature or request 1.21.3 Targeted at Minecraft 1.21.3 labels Nov 1, 2024
@TelepathicGrunt TelepathicGrunt self-assigned this Nov 1, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Nov 1, 2024

  • Publish PR to GitHub Packages

Last commit published: 157f2449845aaa72b786be9e45525ba46a499738.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1652' // https://github.com/neoforged/NeoForge/pull/1652
        url 'https://prmaven.neoforged.net/NeoForge/pr1652'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1652.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1652
cd NeoForge-pr1652
curl -L https://prmaven.neoforged.net/NeoForge/pr1652/net/neoforged/neoforge/21.3.12-beta-pr-1652-DefaultRangeValueInConfigFile2/mdk-pr1652.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@Technici4n
Copy link
Member

Can you show an example of what this looks like? We could also put it on the same line as something else. For example:

# Configure how much power the machine needs. (Default: 3)
# Range: 1-5.

@TelepathicGrunt
Copy link
Contributor Author

Was taking me a while to launch game with example.
image

That is what is looks like. I would encourage not putting it on the same line as the modder created config. That will be gross.

Either same line as range somehow or below range

@Technici4n
Copy link
Member

How about default first and then range? It doesn't really matter I know 😅

@TelepathicGrunt
Copy link
Contributor Author

visual aid
image

@Technici4n
Copy link
Member

We can merge tomorrow to give more time for feedback.

@Shadows-of-Fire
Copy link
Contributor

Thoughts on making it # Default (With a space) and applying the same change to # Range as well? That seems to be more consistent with the placement of the user-provided comment.

@Technici4n Technici4n merged commit 521fced into neoforged:1.21.x Nov 4, 2024
6 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.3.11-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.3 Targeted at Minecraft 1.21.3 enhancement New (or improvement to existing) feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config file should mention the default value next to the range
3 participants