Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maybe fix #1644 datagen issue. #1645

Closed
wants to merge 2 commits into from

Conversation

gigaherz
Copy link
Contributor

@gigaherz gigaherz commented Oct 30, 2024

I have no idea if this actually fixes #1644 what I intended to fix, but I hope it does.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Oct 30, 2024

  • Publish PR to GitHub Packages

Last commit published: 63569afbf41d04a0fd31d7ca886ae9cd4c574432.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1645' // https://github.com/neoforged/NeoForge/pull/1645
        url 'https://prmaven.neoforged.net/NeoForge/pr1645'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1645.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1645
cd NeoForge-pr1645
curl -L https://prmaven.neoforged.net/NeoForge/pr1645/net/neoforged/neoforge/21.3.8-beta-pr-1645-holder-lookup-issue/mdk-pr1645.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@gigaherz gigaherz changed the title Maybe fix datagen issue. Maybe fix #1644 datagen issue. Oct 30, 2024
@XFactHD
Copy link
Member

XFactHD commented Oct 31, 2024

Superceded by #1648.

@XFactHD XFactHD closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HolderOwners being wrapped messing up RegistryFixedCodec
2 participants