Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21.3] Fix nametag rendering and optional text filtering #1604

Merged
merged 4 commits into from
Nov 10, 2024

Conversation

XFactHD
Copy link
Member

@XFactHD XFactHD commented Oct 19, 2024

This PR fixes nametags rendering with varying brightness depending on the camera angle and makes the optional texture filtering compatible with batching in GuiGraphics.

@XFactHD XFactHD added rendering Related to rendering 1.21.2 Targeted at Minecraft 1.21.2 labels Oct 19, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Oct 19, 2024

  • Publish PR to GitHub Packages

Last commit published: be47e519671ccbd460fb06ffe496d7d7a5b5bbeb.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1604' // https://github.com/neoforged/NeoForge/pull/1604
        url 'https://prmaven.neoforged.net/NeoForge/pr1604'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1604.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1604
cd NeoForge-pr1604
curl -L https://prmaven.neoforged.net/NeoForge/pr1604/net/neoforged/neoforge/21.3.17-beta-pr-1604-text_rendertype/mdk-pr1604.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@Technici4n Technici4n deleted the branch neoforged:1.21.x October 22, 2024 16:31
@Technici4n Technici4n closed this Oct 22, 2024
@Technici4n Technici4n reopened this Oct 22, 2024
@Technici4n Technici4n changed the base branch from port/1.21.2 to 1.21.x October 22, 2024 16:43
@neoforged-compatibility-checks
Copy link

neoforged-compatibility-checks bot commented Oct 23, 2024

@XFactHD, this PR introduces breaking changes.
Fortunately, this project is currently accepting breaking changes, but if they are not intentional, please revert them.
Last checked commit: be47e519671ccbd460fb06ffe496d7d7a5b5bbeb.

Compatibility checks

neoforge (:neoforge)

  • net/neoforged/neoforge/client/NeoForgeRenderTypes$Internal
    • TEXT_SEETHROUGH:Ljava/util/function/Function;: ❗ API field was removed
    • TEXT_INTENSITY_POLYGON_OFFSET:Ljava/util/function/Function;: ❗ API field was removed
    • TEXT_INTENSITY:Ljava/util/function/Function;: ❗ API field was removed
    • TEXT_POLYGON_OFFSET:Ljava/util/function/Function;: ❗ API field was removed
    • TEXT:Ljava/util/function/Function;: ❗ API field was removed
    • TEXT_INTENSITY_SEETHROUGH:Ljava/util/function/Function;: ❗ API field was removed
  • net/neoforged/neoforge/client/NeoForgeRenderTypes
    • getText(Lnet/minecraft/resources/ResourceLocation;)Lnet/minecraft/client/renderer/RenderType;: ❗ API method was removed
    • getTextSeeThrough(Lnet/minecraft/resources/ResourceLocation;)Lnet/minecraft/client/renderer/RenderType;: ❗ API method was removed
    • getTextIntensity(Lnet/minecraft/resources/ResourceLocation;)Lnet/minecraft/client/renderer/RenderType;: ❗ API method was removed
    • getTextPolygonOffset(Lnet/minecraft/resources/ResourceLocation;)Lnet/minecraft/client/renderer/RenderType;: ❗ API method was removed
    • getTextIntensityPolygonOffset(Lnet/minecraft/resources/ResourceLocation;)Lnet/minecraft/client/renderer/RenderType;: ❗ API method was removed
    • getTextIntensitySeeThrough(Lnet/minecraft/resources/ResourceLocation;)Lnet/minecraft/client/renderer/RenderType;: ❗ API method was removed
    • enableTextTextureLinearFiltering:Z: ❗ API field was removed

@XFactHD XFactHD changed the title [1.21.2] Fix nametag rendering and optional text filtering [1.21.3] Fix nametag rendering and optional text filtering Nov 8, 2024
@XFactHD XFactHD added 1.21.3 Targeted at Minecraft 1.21.3 and removed 1.21.2 Targeted at Minecraft 1.21.2 labels Nov 8, 2024
@Shadows-of-Fire
Copy link
Contributor

Looks fine otherwise, just a couple comments to be added to patched-in methods

@TelepathicGrunt TelepathicGrunt merged commit 82eddb0 into neoforged:1.21.x Nov 10, 2024
6 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.3.23-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.3 Targeted at Minecraft 1.21.3 rendering Related to rendering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants