-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use an in-tree Gradle plugin instead of an external Gradle Plugin to make version-specific changes easier #1485
Conversation
Last commit published: a71e50cabe457910873f013348ee534032b5ff85. PR PublishingThe artifacts published by this PR:
Repository DeclarationIn order to use the artifacts published by the PR, add the following repository to your buildscript: repositories {
maven {
name 'Maven for PR #1485' // https://github.com/neoforged/NeoForge/pull/1485
url 'https://prmaven.neoforged.net/NeoForge/pr1485'
content {
includeModule('net.neoforged', 'testframework')
includeModule('net.neoforged', 'neoforge')
}
}
} MDK installationIn order to setup a MDK using the latest PR version, run the following commands in a terminal. mkdir NeoForge-pr1485
cd NeoForge-pr1485
curl -L https://prmaven.neoforged.net/NeoForge/pr1485/net/neoforged/neoforge/21.3.77-beta-pr-1485-features-moddevgradle/mdk-pr1485.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip To test a production environment, you can download the installer from here. |
@Technici4n, this pull request has conflicts, please resolve them for this PR to move forward. |
a706b07
to
625530a
Compare
14807ec
to
c3aee1d
Compare
@Technici4n, this pull request has conflicts, please resolve them for this PR to move forward. |
b4b12af
to
ecad716
Compare
026d7fe
to
c13928a
Compare
@Technici4n, this pull request has conflicts, please resolve them for this PR to move forward. |
c64aac5
to
2af9644
Compare
Eclipse support appears to be fully functional from what checks I can run. Import works, launch configs (client/server) both operate. I'm not sure if there's supposed to be launch groups getting generated instead of pure application launch configs, but the application configs are working. |
Thanks for checking! Indeed, application configs should work. There is no Gradle prepare task anymore. |
This reverts commit e8f2275.
🚀 This PR has been released as NeoForge version |
This PR replaces our use of NG by a custom plugin that is based on NFRT and MDG, and lives in the
buildSrc/
folder.The main advantages are as follows:
Future developments that I have in mind:
includeBuild
for NeoForge.TODO:
io.codechicken
variant.