Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instead of relying on a global placeholder, bake the version into the neoforge.mods.toml #1207

Merged

Conversation

shartte
Copy link
Contributor

@shartte shartte commented Jul 1, 2024

Currently, it's not possible to get the version of NeoForge simply based on the jar file itself, since it sets its own version to whatever was passed on the CLI commandline.

This PR changes that by replacing the placeholder with the actual project version number, when NF is built.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jul 1, 2024

  • Publish PR to GitHub Packages

Last commit published: ccb2af05e927933d23e557d634557db200f06646.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1207' // https://github.com/neoforged/NeoForge/pull/1207
        url 'https://prmaven.neoforged.net/NeoForge/pr1207'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1207.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1207
cd NeoForge-pr1207
curl -L https://prmaven.neoforged.net/NeoForge/pr1207/net/neoforged/neoforge/21.0.45-beta-pr-1207-bake-version-into-neoforge-mods-toml/mdk-pr1207.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@shartte shartte requested a review from marchermans July 1, 2024 00:01
@shartte shartte force-pushed the bake-version-into-neoforge-mods-toml branch from 1419d85 to ccb2af0 Compare July 1, 2024 00:01
@shartte shartte merged commit 650d3a0 into neoforged:1.21.x Jul 2, 2024
6 checks passed
@shartte shartte deleted the bake-version-into-neoforge-mods-toml branch July 2, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants