Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.20.x] Fix patch conflicts introduced by #999 #1057

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

Shadows-of-Fire
Copy link
Contributor

@Shadows-of-Fire Shadows-of-Fire commented Jun 4, 2024

pls help I cannot import the neo foreg thank you

(I still can't, pls help)

Merging of #999 introduced a patch conflict due to a change that was made between its last pipeline run and time of merge, this PR fixes that

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Jun 4, 2024

  • Publish PR to GitHub Packages

Last commit published: cb5cb3ce30e289986828f56f01c25123a25707e5.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1057' // https://github.com/neoforged/NeoForge/pull/1057
        url 'https://prmaven.neoforged.net/NeoForge/pr1057'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1057.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1057
cd NeoForge-pr1057
curl -L https://prmaven.neoforged.net/NeoForge/pr1057/net/neoforged/neoforge/20.6.106-beta-pr-1057-what/mdk-pr1057.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@Shadows-of-Fire Shadows-of-Fire enabled auto-merge (squash) June 4, 2024 05:36
sciwhiz12
sciwhiz12 previously approved these changes Jun 4, 2024
marchermans
marchermans previously approved these changes Jun 4, 2024
@Shadows-of-Fire Shadows-of-Fire dismissed stale reviews from marchermans and sciwhiz12 via ccd9715 June 4, 2024 06:14
@Shadows-of-Fire Shadows-of-Fire changed the title bump NG to fix Eclipse imports Fix patch apply failures and eclipse imports Jun 4, 2024
@Shadows-of-Fire
Copy link
Contributor Author

Updated to include a patch apply fix for an issue caused by merge of #999

@Shadows-of-Fire
Copy link
Contributor Author

Due to issues with NG > 136 this PR now is just a fix for patch conflicts.

You really can't tell where things are going sometimes

@Shadows-of-Fire Shadows-of-Fire changed the title Fix patch apply failures and eclipse imports [1.20.x] Fix patch conflicts introduced by #999 Jun 4, 2024
@Shadows-of-Fire Shadows-of-Fire disabled auto-merge June 4, 2024 07:11
@Shadows-of-Fire Shadows-of-Fire merged commit 623cf3b into neoforged:1.20.x Jun 4, 2024
4 checks passed
@tmvkrpxl0
Copy link
Contributor

I like how everything went unexpected here

shartte added a commit to shartte/NeoForge that referenced this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants