Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new constructor to SwordItem to allow setting Tool data component #1046

Merged

Conversation

TelepathicGrunt
Copy link
Contributor

Gives complete control over the Tool component to modders so they can do whatever they need to do

Closes #1045

@TelepathicGrunt TelepathicGrunt added enhancement New (or improvement to existing) feature or request 1.20.6 Targeted at Minecraft 1.20.6 labels May 31, 2024
@TelepathicGrunt TelepathicGrunt self-assigned this May 31, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented May 31, 2024

  • Publish PR to GitHub Packages

Last commit published: aad736e6f4f5b0eb4b37f8557479aa274cdfbc02.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1046' // https://github.com/neoforged/NeoForge/pull/1046
        url 'https://prmaven.neoforged.net/NeoForge/pr1046'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1046.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1046
cd NeoForge-pr1046
curl -L https://prmaven.neoforged.net/NeoForge/pr1046/net/neoforged/neoforge/20.6.104-beta-pr-1046-SwordItemImprovement/mdk-pr1046.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@Tslat
Copy link

Tslat commented Jun 1, 2024

Don't suppose you can public that createToolProperties static method while you're there?

Can't re-use it as it stands without an additional AT

@Shadows-of-Fire Shadows-of-Fire merged commit b96af76 into neoforged:1.20.x Jun 4, 2024
4 checks passed
@TelepathicGrunt TelepathicGrunt deleted the SwordItemImprovement branch June 12, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.20.6 Targeted at Minecraft 1.20.6 enhancement New (or improvement to existing) feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect SwordItem#<init>'s createToolProperties call to an instance method so it can be overridden
4 participants