Expose ItemEntity#target's value in ItemEntityPickupEvent

[TelepathicGrunt]

This is breaking for anyone calling the hooks themselves but that should be ok since we are still in beta phase and event is new.

Closes #1003

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: 0c5f8cde82b3590a68930c5e060669a71ff5d30c.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged:testframework:20.6.108-beta-pr-1009-ItemPickupEventTarget
• 📦 net.neoforged:neoforge:20.6.108-beta-pr-1009-ItemPickupEventTarget

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1009' // https://github.com/neoforged/NeoForge/pull/1009
        url 'https://prmaven.neoforged.net/NeoForge/pr1009'
        content {
            includeModule('net.neoforged', 'testframework')
            includeModule('net.neoforged', 'neoforge')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1009.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1009
cd NeoForge-pr1009
curl -L https://prmaven.neoforged.net/NeoForge/pr1009/net/neoforged/neoforge/20.6.108-beta-pr-1009-ItemPickupEventTarget/mdk-pr1009.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

[Matyrobbrt]

Doc nitpicks

[Shadows-of-Fire]

Does it make more sense to just patch in a getter method for ItemEntity#target and/or just apply the AT for it? There's already a public setter, so its not like encapsulation is a concern.

If any other item-related events need the target, that approach will require fewer changes

[TelepathicGrunt]

@Shadows-of-Fire wha. Why mojang add setter but no getter? Huh. Yeah a getter patched in would be ideal imo.