Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate FMLJavaModLoadingContext for removal #47

Merged
merged 2 commits into from
Dec 8, 2023
Merged

Deprecate FMLJavaModLoadingContext for removal #47

merged 2 commits into from
Dec 8, 2023

Conversation

dima-dencep
Copy link
Contributor

@dima-dencep dima-dencep commented Dec 5, 2023

As requested.

How do we handle this after getModEventBus got removed?

What about updating other javadocs that have this method?

@Technici4n
Copy link
Member

How do we handle this after getModEventBus got removed?

IMO we can remove the supplier from Mod.EventBusSubscriber.Bus, and instead pass the mod bus to AutomaticEventSubscriber#inject.

What about updating other javadocs that have this method?

I would suggest linking ModContainer#getEventBus instead. But we are going to look into moving most events to the normal forge bus soon:TM:, so we can leave the old javadoc in place since it will have to change anyway.

@Technici4n Technici4n merged commit 3447c36 into neoforged:main Dec 8, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants