Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split data targets for 1.21.4 and remove deprecations. #217

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

shartte
Copy link
Contributor

@shartte shartte commented Nov 23, 2024

No description provided.

@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Nov 23, 2024

  • Publish PR to GitHub Packages

Last commit published: 7ba2672d70f496f19dca6a5ad815c088a9d88fc8.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #217' // https://github.com/neoforged/FancyModLoader/pull/217
        url 'https://prmaven.neoforged.net/FancyModLoader/pr217'
        content {
            includeModule('net.neoforged.fancymodloader', 'junit-fml')
            includeModule('net.neoforged.fancymodloader', 'loader')
            includeModule('net.neoforged.fancymodloader', 'tests')
            includeModule('net.neoforged.fancymodloader', 'earlydisplay')
        }
    }
}

@shartte shartte requested a review from Technici4n November 23, 2024 16:24
@neoforged-compatibility-checks
Copy link

neoforged-compatibility-checks bot commented Nov 23, 2024

@shartte, this PR introduces breaking changes.
Fortunately, this project is currently accepting breaking changes, but if they are not intentional, please revert them.
Last checked commit: 7ba2672d70f496f19dca6a5ad815c088a9d88fc8.

Compatibility checks

loader (:loader)

  • net/neoforged/fml/loading/targets/NeoForgeServerLaunchHandler
    • ❗ Class missing superclass of net/neoforged/fml/loading/targets/CommonServerLaunchHandler
    • getAdditionalMinecraftJarContent(Lnet/neoforged/fml/loading/VersionInfo;)Ljava/util/List;: ❗ API method was removed
  • net/neoforged/fml/loading/targets/NeoForgeDataUserdevLaunchHandler
    • ❗ API class no longer exists
  • net/neoforged/fml/loading/targets/NeoForgeClientLaunchHandler
    • ❗ Class missing superclass of net/neoforged/fml/loading/targets/CommonClientLaunchHandler
    • getAdditionalMinecraftJarContent(Lnet/neoforged/fml/loading/VersionInfo;)Ljava/util/List;: ❗ API method was removed
  • net/neoforged/fml/loading/targets/CommonServerLaunchHandler
    • ❗ API class no longer exists
  • net/neoforged/fml/loading/targets/JUnitUserDevLaunchTarget
    • ❗ API class no longer exists
  • net/neoforged/fml/loading/targets/NeoForgeClientUserdevLaunchHandler
    • ❗ API class no longer exists
  • net/neoforged/fml/loading/targets/NeoForgeClientDevLaunchHandler
    • ❗ Class missing superclass of net/neoforged/fml/loading/targets/CommonDevLaunchHandler
  • net/neoforged/fml/loading/targets/JUnitDevLaunchTarget
    • ❗ Class missing superclass of net/neoforged/fml/loading/targets/CommonDevLaunchHandler
  • net/neoforged/fml/loading/targets/CommonClientLaunchHandler
    • ❗ API class no longer exists
  • net/neoforged/fml/loading/targets/NeoForgeServerDevLaunchHandler
    • ❗ Class missing superclass of net/neoforged/fml/loading/targets/CommonDevLaunchHandler
  • net/neoforged/fml/loading/targets/NeoForgeDataDevLaunchHandler
    • ❗ API class no longer exists
  • net/neoforged/fml/loading/targets/CommonLaunchHandler
    • isData()Z: ❗ API method was removed
    • dataService([Ljava/lang/String;Ljava/lang/ModuleLayer;)V: ❗ API method was removed
  • net/neoforged/fml/loading/targets/NeoForgeServerUserdevLaunchHandler
    • ❗ API class no longer exists
  • net/neoforged/fml/loading/targets/CommonDevLaunchHandler
    • ❗ API class no longer exists

@shartte shartte merged commit a031181 into neoforged:main Nov 29, 2024
3 checks passed
@shartte shartte deleted the split-data-targets branch November 29, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants