Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate userdev launch targets and merge them into the dev launch targets #215

Merged
merged 7 commits into from
Nov 23, 2024

Conversation

shartte
Copy link
Contributor

@shartte shartte commented Nov 20, 2024

This merges the logic that supports loading Minecraft from a userdev jar into the dev launch targets and deprecated them.

As a result of this, it should become possible to run a mod with an includeBuild of NeoForge and we can use the same userdev config file for launching in neodev and userdev.

@shartte shartte changed the title Merge dev and userdev targets Deprecate userdev launch targets and merge them into the dev launch targets Nov 20, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Nov 20, 2024

  • Publish PR to GitHub Packages

Last commit published: c303def72d6ab1d7ac22da900c07a7e48f93d5a8.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #215' // https://github.com/neoforged/FancyModLoader/pull/215
        url 'https://prmaven.neoforged.net/FancyModLoader/pr215'
        content {
            includeModule('net.neoforged.fancymodloader', 'junit-fml')
            includeModule('net.neoforged.fancymodloader', 'loader')
            includeModule('net.neoforged.fancymodloader', 'tests')
            includeModule('net.neoforged.fancymodloader', 'earlydisplay')
        }
    }
}

@neoforged-compatibility-checks
Copy link

neoforged-compatibility-checks bot commented Nov 20, 2024

@shartte, this PR introduces breaking changes.
Fortunately, this project is currently accepting breaking changes, but if they are not intentional, please revert them.
Last checked commit: c303def72d6ab1d7ac22da900c07a7e48f93d5a8.

loader (:loader)

  • net/neoforged/fml/loading/targets/NeoForgeDataUserdevLaunchHandler
    • ❗ Class missing superclass of net/neoforged/fml/loading/targets/NeoForgeUserdevLaunchHandler
  • net/neoforged/fml/loading/targets/NeoForgeUserdevLaunchHandler
    • ❗ API class no longer exists
  • net/neoforged/fml/loading/targets/JUnitUserDevLaunchTarget
    • ❗ Class missing superclass of net/neoforged/fml/loading/targets/NeoForgeUserdevLaunchHandler
  • net/neoforged/fml/loading/targets/NeoForgeServerUserdevLaunchHandler
    • ❗ Class missing superclass of net/neoforged/fml/loading/targets/NeoForgeUserdevLaunchHandler
  • net/neoforged/fml/loading/targets/CommonUserdevLaunchHandler
    • ❗ API class no longer exists
  • net/neoforged/fml/loading/targets/NeoForgeClientUserdevLaunchHandler
    • ❗ Class missing superclass of net/neoforged/fml/loading/targets/NeoForgeUserdevLaunchHandler

@shartte shartte merged commit e45a8db into neoforged:main Nov 23, 2024
3 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as FancyModLoader version 5.0.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants