Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete method api key authentication method is 'get' typo #11

Open
kouyouelysian opened this issue Mar 11, 2024 · 0 comments
Open

Delete method api key authentication method is 'get' typo #11

kouyouelysian opened this issue Mar 11, 2024 · 0 comments

Comments

@kouyouelysian
Copy link

Hi, Neocities team!

No clue how it slipped past so many people for over 6 years, but i found a bug in the Python API wrapper that you provide (thank you for your generousity, it really helps with my project!)

So it's possible to delete files using log:pass auth using the wrapper. But for token-based auth, the request method is "get" instead of "post", which is not the expected request type. I think that's just a typo; i changed it to "post" on my local copy and now it works.

The line with the bug is #79 @ https://github.com/neocities/python-neocities/blob/master/neocities/neocities.py

Thanx for providing the tools, and i hope this helps improve this one even if just a bit <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant