Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request - 6.0] Pass context to logging functions #528

Open
adrianiacobghiula opened this issue Sep 8, 2023 · 1 comment
Open

Comments

@adrianiacobghiula
Copy link

Hi,

In the ideea of having a consistent trace of a request in the logs is it possible to have the context as first parameter in the logging functions ( https://github.com/neo4j/neo4j-go-driver/blob/5.0/neo4j/log/logger.go#L46-L49 ) .I believe one could, then, add a "requestID" in the context and expect to have this parameter in a custom implementation of the logger to print it

Thank you

@robsdedude
Copy link
Member

robsdedude commented Dec 21, 2023

Thanks for the suggestion.

This certainly cannot happen before 6.0 as it constitutes a breaking change.

Generally, I think this change provides value 👍

@robsdedude robsdedude changed the title [Feature Request] Logging functions & context [Feature Request - 6.0] Pass context to logging functions Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants