Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on typos for uniqueness #697

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

gem-neo4j
Copy link
Contributor

If a user types in the an invalid uniqueness value, they wouldn't know, so this will now error; #85

@gem-neo4j
Copy link
Contributor Author

Copy link
Contributor

@loveleif loveleif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

", ",
java.util.Arrays.stream(Uniqueness.values())
.map(Enum::name)
.toArray(String[]::new))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a .collect(Collectors.joining(" ,")), but this is fine too :).

@gem-neo4j gem-neo4j merged commit 311a019 into dev Dec 9, 2024
10 of 11 checks passed
@gem-neo4j gem-neo4j deleted the dev_error_on_typos_for_uniqueness branch December 9, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants