[EUtjTRHb] Better error handling and logging during cleanup of triggers #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
loveleif
commented
Nov 4, 2024
loveleif
commented
- Add better logging when apoc fails to cleanup triggers during database drop.
- Ignore trigger cleanup when system db is unavailable.
loveleif
commented
Nov 4, 2024
Comment on lines
+178
to
+183
| if (!db.isAvailable()) { | ||
| userLog.warn( | ||
| "Database %s not available, skipping apoc trigger cleanup of database %s.", | ||
| db.databaseName(), dbName); | ||
| return; | ||
| } |
There was a problem hiding this comment.
We risk leaving triggers laying around for dropped databases. But what else can we do if system db is unavailable?
There was a problem hiding this comment.
I think this is reasonable, not much more we can do if the db is unavailable
loveleif
commented
Nov 4, 2024
| } catch (Exception e) { | ||
| userLog.error( | ||
| "Failed to cleanup apoc triggers during database drop of %s: %s".formatted(dbName, e), e); | ||
| throw e; |
There was a problem hiding this comment.
Should we even swallow this exception?
There was a problem hiding this comment.
Makes sense, updated the PR to ignore this error.
gem-neo4j
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.