Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor independent db functions into Database #739

Open
aanastasiou opened this issue Aug 22, 2023 · 0 comments
Open

Refactor independent db functions into Database #739

aanastasiou opened this issue Aug 22, 2023 · 0 comments

Comments

@aanastasiou
Copy link
Collaborator

Feature description (Mandatory)

A number of functions in neomodel/core.py and neomodel/util.py take a db argument whether explicitly, or implicitly (i.e. take db from the global context).

These can be refactored under the Database class.

This will result in better code organisation and it will also avoid circular import issues that appear at the moment when working on more advanced features.

However, this will also have a relatively large impact on tests and possibly user code, so it has to be scheduled for release appropriately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants