-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[api] delete file #1122
Open
MalinAhlberg
wants to merge
18
commits into
main
Choose a base branch
from
feature/api-delete-file
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[api] delete file #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MalinAhlberg
force-pushed
the
feature/api-delete-file
branch
7 times, most recently
from
November 21, 2024 10:15
e7e259f
to
b31bc38
Compare
MalinAhlberg
force-pushed
the
feature/api-delete-file
branch
from
November 21, 2024 10:22
b31bc38
to
446a1ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s) and PR(s)
This PR closes #1134 .
Description
This PR adds the delete file functionality to the
api
component. Specifically, it deletes the file from the inbox and it adds a new file log event, setting the file status todisabled
.Also, it adds the
fileID
to thelist
functionality of theapi
, since that field is needed in order to delete a file:How to test
make build-all
thenPR_NUMBER=$(date +%F) docker compose -f .github/integration/sda-s3-integration.yml run integration_test
.List the files (eg with
http://localhost:8090/users/[email protected]/files
) and make sure files in the inbox can be deleted, and that archived files can not be deleted.