From 95d2dcf48a3c6252d6a47614406ceab1da7aa43d Mon Sep 17 00:00:00 2001 From: Neel Doshi Date: Sat, 6 Jul 2024 05:35:16 +0530 Subject: [PATCH] Deps: Migrated `googlePlayReview` to Version Catalog --- WordPress/build.gradle | 4 ++-- build.gradle | 1 - gradle/libs.versions.toml | 3 +++ 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/WordPress/build.gradle b/WordPress/build.gradle index 4dd089718516..788301c58e30 100644 --- a/WordPress/build.gradle +++ b/WordPress/build.gradle @@ -431,8 +431,8 @@ dependencies { implementation libs.androidx.lifecycle.livedata.ktx implementation libs.androidx.lifecycle.process implementation "com.android.volley:volley:$androidVolleyVersion" - implementation "com.google.android.play:review:$googlePlayReviewVersion" - implementation "com.google.android.play:review-ktx:$googlePlayReviewVersion" + implementation libs.google.play.review + implementation libs.google.play.review.ktx implementation "com.google.android.gms:play-services-auth:$googlePlayServicesAuthVersion" implementation "com.google.mlkit:barcode-scanning-common:$googleMLKitBarcodeScanningCommonVersion" implementation "com.google.mlkit:text-recognition:$googleMLKitTextRecognitionVersion" diff --git a/build.gradle b/build.gradle index 3f20286efe2e..1192e8298a06 100644 --- a/build.gradle +++ b/build.gradle @@ -61,7 +61,6 @@ ext { googleMLKitBarcodeScanningVersion = '17.2.0' googleMLKitBarcodeScanningCommonVersion = '17.0.0' googleMLKitTextRecognitionVersion = '16.0.0' - googlePlayReviewVersion = '2.0.1' googlePlayServicesAuthVersion = '20.4.1' googlePlayServicesCodeScannerVersion = '16.0.0-beta3' jsoupVersion = '1.16.2' diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml index e6c02d98b926..3f18f79fc35f 100644 --- a/gradle/libs.versions.toml +++ b/gradle/libs.versions.toml @@ -31,6 +31,7 @@ soLoader = '0.10.5' wordPressPersistentEditText = '1.0.2' wiremock = '2.26.3' wiremockHttpClient = '4.3.5.1' +googlePlayReview = '2.0.1' [libraries] android-appUpdate = { group = "com.google.android.play", name = "app-update", version.ref = "googlePlayAppUpdate" } @@ -116,6 +117,8 @@ mockito-kotlin = { group = "org.mockito.kotlin", name = "mockito-kotlin", versio wiremock = { group = "com.github.tomakehurst", name = "wiremock", version.ref ="wiremock" } wiremock-httpclient-android = { group = "org.apache.httpcomponents", name = "httpclient-android", version.ref ="wiremockHttpClient" } wordPress-persistentEditText = { group = "org.wordpress", name = "persistentedittext", version.ref = "wordPressPersistentEditText" } +google-play-review = { group = "com.google.android.play", name = "review", version.ref ="googlePlayReview" } +google-play-review-ktx = { group = "com.google.android.play", name = "review-ktx", version.ref ="googlePlayReview" } [plugins] dagger = { id = "com.google.dagger.hilt.android", version.ref = "dagger" }