Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversion of Code to a Proper Design Architecture (MVVM) #8

Open
3 tasks
neeldoshii opened this issue Oct 1, 2023 · 8 comments
Open
3 tasks

Conversion of Code to a Proper Design Architecture (MVVM) #8

neeldoshii opened this issue Oct 1, 2023 · 8 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest hacktoberfest-accepted Migrate Migrate towards jetpack compose & MVVM Architecture

Comments

@neeldoshii
Copy link
Owner

Description:

I developed this application while I was learning Android Application. So I just wrote the code in a gibberish format. Would like to have this project migrated towards Jetpack Compose & MVVM Architecture, also would like to have view-binding throughout the application.

Migrate the app in phases to form a clean structure.

  • Homepage
  • Add Task Bottomsheet
  • Task Details Screen

Open for suggestions to increase more features, providing a good UI/UX throughout the application.

@neeldoshii neeldoshii added the Migrate Migrate towards jetpack compose & MVVM Architecture label Oct 1, 2023
@TharunBalaji2004
Copy link
Contributor

Hello @neeldoshii, I'm interested to work on migrating the app to MVVM architecture. I have already built few projects which follows MVVM along with Hilt Dependency Injection. Some of my works 👇

Also I will try to improve the UI and visual appearance of Home screen and adding tasks and schedule 👍

@neeldoshii
Copy link
Owner Author

Works, I have assigned you with the task.

Just convert the code in phase by phase. We are not in hurry. I would like not to have repository as it just increases overall complexity rest full MVVM design part what do you think. Since we need to have offline/online database do you think we should maintain repository.

Also Tharun check this Comment

Thank You

@TharunBalaji2004
Copy link
Contributor

Alright @neeldoshii , let me start with migrating the code phase by phase and since we are moving towards hybrid model of app, I think repository could also be used as the data would be uploaded and downloaded to ROOM and Firebase 👍

Let me start with setting up Hilt and changing into Jetpack Navigation

@neeldoshii
Copy link
Owner Author

@TharunBalaji2004 sure go ahead.

@TharunBalaji2004
Copy link
Contributor

TharunBalaji2004 commented Oct 16, 2023

Hey there @neeldoshii just wanted to give a quick update about the issue.

Completed work

  • Hilt Setup for Retrofit and ROOM

  • Main Fragment migrated to MVVM

  • Adding of new task to ROOM DB

Pending work

  • Implementation of Task Exec screen
  • Perform timer updation operations

I have made some minor changes to look fine, checkout the below video 👇

timetracker_migrate1.mp4

@neeldoshii
Copy link
Owner Author

Looks good! Great Going
I think we should be removing the Quote API in future (not now) as it doesn't corelates and align with our app idea. Its not motivative, I have idea of gamify it and add it coin based instead such that when user for ex puts his 30 minutes on some task, he will get rewarded by some coins and those coins can be redeemable to gift cards, coupons or affiliated partnered coupons depends on feasibility.

We will push this idea in 2nd phase and then deploy it to play store. I do have designs and plan in mind but this exams just came in between and ruined my time though lol :D

Since we all are in college going I think this will be very good project for all of us for resume perspective too.

Do you want any group discussion chat place? @TharunBalaji2004 @bhaskarblur

@bhaskarblur
Copy link
Contributor

Hi,
Discord channel will be good in this case and it will build up a community as well.

@TharunBalaji2004
Copy link
Contributor

That's great @neeldoshii, the Forest app which you shared was really amazing. It was quite a mix of productivity and gamification rewards such as planting small to big trees based on the level of productivity

As @bhaskarblur said, we could create a group for further discussion. All the best for your exams! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest hacktoberfest-accepted Migrate Migrate towards jetpack compose & MVVM Architecture
Projects
None yet
Development

No branches or pull requests

3 participants