RIDI Bonus Over Ocean for Flying Mounts #150
Labels
Comments
nedbrek
pushed a commit
that referenced
this issue
Nov 2, 2023
Because these changes are going to be somewhat far-reaching, I am going to do these in smaller chunks. This chunk will contain - a new game config which defaults to not outputting json reports. - the inclusion of the nlohmann/json.hpp single-file json parser/manipulation library. - Output the basic faction info (meaning the fields on the faction itself, but NOT deeper structures like regions/objects/units) - An example of some small nested structures (skill shows/faction stats) to give examples of how this stuff will work. - A renaming of 2 rules helper functions from link/link_ref to url/achor in order to avoid a conflict with the link() function from unistd.h which gets pulled in via the nlohmann/json.hpp standard library includes, and which caused the rules to break. This is JUST a renaming and no functionality change, so you can ignore all the changes in genrules.cpp as part of this. - Removing some duplicated skill data which was being output if you were shown a skill description which allowed you create an object which in turn allowed you to use a skill (create staff of healing shows the staff of healing, which then adds a skill show for magic healing). This wouldn't affect a player since a faction tracks whether or not a skill has been shown permanently and never shows it again, but when generating the turn 1 report for the gamemaster, if those items were enabled, 4 skills would end up shown twice. This also accounts for the change to the snapshot turn_0 report.1 file. Those changes are expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With the fix for drowning monsters in #142, combat may occur over oceans. Adding the ability to using flying mounts (ship based or moving via flying) to the ocean terrain would allow Dragon, Winged Horse, etc mounts to be useful.
Change is in TerrainType in gamedata.cpp (TerrainType::FLYINGMOUNTS).
The text was updated successfully, but these errors were encountered: