Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spell Description vs Actual Damage Discrepancy #15

Open
Mochnant opened this issue Jan 26, 2017 · 0 comments
Open

Spell Description vs Actual Damage Discrepancy #15

Mochnant opened this issue Jan 26, 2017 · 0 comments
Labels

Comments

@Mochnant
Copy link
Collaborator

There is a disconnect between how spells and special attack damage is calculated, and how it is reported in the skill descriptions.

https://github.com/nedbrek/Atlantis/blob/TrueAtlanteans/specials.cpp#L211-L212

int realtimes = spd->damage[i].minnum + getrandom(times) +
	getrandom(times);

In the case of FIRE, this results in 2-12 damage, not the expected 2-10.

fire [FIRE] 1:  A mage with this skill can cast a fireball in battle.
  This ability does between 2 and 10 times the skill level of the mage
  energy attacks.

Additionally, the description itself is vague, in that "between 2 and 10 times the skill level" could be reasonably interpreted to mean (for level 5) 2-50 or 10-50.

There is also no indication that the damage is skewed to the midline of the range, not truly random.

Proposed fix would be to adjust the skill descriptions to be in line with current code.

@Mochnant Mochnant added the Bug label Jan 26, 2017
Repository owner deleted a comment from nedbrek Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant