Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pop-up stream player doesn't use FQDN #16

Open
frecuencialibre opened this issue Oct 30, 2018 · 2 comments
Open

pop-up stream player doesn't use FQDN #16

frecuencialibre opened this issue Oct 30, 2018 · 2 comments
Labels
configuration-support Configuration/Support Related enhancement New feature or request

Comments

@frecuencialibre
Copy link
Collaborator

if you click the "listen" button, right below the "ON AIR" indicator in the top right of the web UI, it opens a window with an audio player. it appears to be hardcoded:

setjPlayer('http://127.0.0.1:8000/airtime_128', 'oga', 'icecast');
@frecuencialibre frecuencialibre added the bug Something isn't working label Oct 30, 2018
@ned-kelly
Copy link
Owner

Right now the stream will default to whatever the FQDN of your Icecast server is in the configuration - the quick fix is to just specify the the Icecast Server as a FQDN rather than localhost or the internal name of the docker-container (how my libretime is setup to talk to the Icecast container).

A possible fix would be to proxy the pop-up player to the same host as the web-ui and then that can talk directly to whatever is configured in the Icecast settings - This way if you're accessing over a VPN etc it will still work fine (even if the Icecast server is not accessible directly).

For now - the quick solution is to just configure the Icecast server to whatever your public Icecast address is.

@ned-kelly ned-kelly added enhancement New feature or request configuration-support Configuration/Support Related and removed bug Something isn't working labels Nov 29, 2018
@frecuencialibre
Copy link
Collaborator Author

the stream will default to whatever the FQDN of your Icecast server is in the configuration

the configuration i've been able to find is at Settings > Streams in the web UI:
screenshot from 2018-12-08 10-39-50

i'm submitting a PR now that gets us most of the way to resolving this out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration-support Configuration/Support Related enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants