Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/divide common.rs into smaller files #373

Open
fadeevab opened this issue Jul 29, 2024 · 1 comment
Open

Refactor/divide common.rs into smaller files #373

fadeevab opened this issue Jul 29, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@fadeevab
Copy link

Reasons / Why

  1. common.rs is ~2600 lines long, it's pretty huge.
  2. It takes roughly 3 thousand light years 10+ seconds for rust-analyzer to recompile it at every change (Ctrl+S)... on my average laptop.
  3. Another reason for refactoring is the fact that common name is too... common.

I was trying to make a simple patch into common.rs, and clippy recompilation delays made it quite challenging.

Thanks :)

@fadeevab fadeevab added the enhancement New feature or request label Jul 29, 2024
@frol
Copy link
Collaborator

frol commented Aug 1, 2024

@fadeevab common.rs is a pile of ugly hacks that we have to decouple into dedicated crates. We have started to work on it here: https://github.com/akorchyn/near-api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants