Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple choice tag naming #62

Open
mikir opened this issue Dec 17, 2024 · 0 comments
Open

Simple choice tag naming #62

mikir opened this issue Dec 17, 2024 · 0 comments
Milestone

Comments

@mikir
Copy link
Collaborator

mikir commented Dec 17, 2024

Example of the current solution for choices:

zserioChoice.emplace<ConditionValue::ChoiceTag::CHOICE_dateRangeOfYear>(computeDateRangeOfYear(value));

It would be good to simplify naming to be less verbose:

  1. To rename ChoiceTag to Tag.
  2. To remove prefix CHOICE_ which is used to prevent clashes with the UNDEFINED_CHOICE.
  3. Consider to use upper case for the first letters of the tags, e.g. DataRangeOfYear.

Reported by @reinco.

@mikir mikir added this to the 0.2.0 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant