Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to extract Zserio wrapper types from detail namespace #58

Open
mikir opened this issue Dec 11, 2024 · 0 comments
Open

Consider to extract Zserio wrapper types from detail namespace #58

mikir opened this issue Dec 11, 2024 · 0 comments
Milestone

Comments

@mikir
Copy link
Collaborator

mikir commented Dec 11, 2024

The base type of the Zserio wrapper types is in the namespace detail. This is a problem if we want to do template metaprogramming. Like support a specific operator only if something is a zserio numeric type.

Example:

template <typename T, 
    std::enable_if_t<std::is_base_of_v<zserio::detail::NumericTypeWrapper<typename T::ValueType>, T>, int> = 0>
void PrintZserioNumericType(const T& t)
{
    std::cout << t.ValueType();
}

Consider to rename wrapper types removing 'wrapper' word as well.

Reported by @reinco.

@mikir mikir modified the milestones: Backlog, 0.2.0 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant