Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to remove checking during writing #35

Open
mikir opened this issue Nov 14, 2024 · 0 comments
Open

Consider to remove checking during writing #35

mikir opened this issue Nov 14, 2024 · 0 comments
Milestone

Comments

@mikir
Copy link
Collaborator

mikir commented Nov 14, 2024

Currently, the following checks are done during writing:

  • If optionals are there (if optional clause is true).
  • If integer values are out of range (like bit:3).

It is a question if this is really necessary if we have validation method now.

However, validation is a separated step, so it would be still possible to call writing without validation resulting in completely wrong binary data.

The similar problem is for bitSizeOf method.

@mikir mikir added this to the Backlog milestone Nov 14, 2024
@mikir mikir changed the title Remove checking during writing Consider to remove checking during writing Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant