Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flakey a11y test #147

Merged
merged 16 commits into from
Jun 19, 2021
Merged

Fix flakey a11y test #147

merged 16 commits into from
Jun 19, 2021

Conversation

nccshecodes
Copy link
Owner

@nccshecodes nccshecodes commented Jun 17, 2021

This PR may not fix all issues with running pa11yci (see open issue links in references) as research indicates there is a bug.

Continuing before server launch complete

The sitemap "http://localhost:5000/sitemap.xml" could not be loaded
yarn run v1.22.10
error Command failed with exit code 1.
$ pa11y-ci --sitemap http://localhost:5000/sitemap.xml --sitemap-find https://shecodes.dev --sitemap-replace http://localhost:5000

This would cause a failure when trying to locate the sitemap to run tests against, which couldn't be found if the server was not yet up and running. I expected wait-on to resolve this but there is an open issue (see references link 1). Adding a manual wait to the github action has fixed this. Will revisit based on outcome of open issue. WIP - experimenting with wait time. Below 5 will intermittently fail.

npx: installed 88 in 4.777s

Puppeteer Errors (WIP)

pa11y-ci intermittently throws an error when running against the sitemap. See references links 3 and 4 which are investigating a bug.

There's a couple of issues I've seen:

  • memory
  • page crash

References

  1. Can't make wait-on work in Github action(open - subscribed)
  2. Pa11y example failing due to Phantom process died error (closed)
  3. Page crash errors when running against a Jekyll site (open - will be closed by #570)
  4. Puppeteer Error: Navigation failed because browser has disconnected! (subscribed)
  5. Leveraging GitHub Actions and pa11y-ci with axe

@nccshecodes nccshecodes marked this pull request as ready for review June 17, 2021 22:31
@nccshecodes nccshecodes merged commit bd7631c into main Jun 19, 2021
@nccshecodes nccshecodes deleted the fix-pa11y-workflow branch June 19, 2021 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant