-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flakey a11y test #147
Merged
Merged
Fix flakey a11y test #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nccshecodes
force-pushed
the
fix-pa11y-workflow
branch
from
June 17, 2021 23:04
ce00a6f
to
e7c163d
Compare
nccshecodes
force-pushed
the
fix-pa11y-workflow
branch
from
June 19, 2021 08:09
80cf878
to
b246472
Compare
…which is not fully supported
…script. Fixes perf hit and accessibility failure where multiple embeds share the same title which must be unique.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR may not fix all issues with running pa11yci (see open issue links in references) as research indicates there is a bug.
Continuing before server launch complete
This would cause a failure when trying to locate the sitemap to run tests against, which couldn't be found if the server was not yet up and running. I expected
wait-on
to resolve this but there is an open issue (see references link 1). Adding a manual wait to the github action has fixed this. Will revisit based on outcome of open issue. WIP - experimenting with wait time. Below 5 will intermittently fail.Puppeteer Errors (WIP)
pa11y-ci intermittently throws an error when running against the sitemap. See references links 3 and 4 which are investigating a bug.
There's a couple of issues I've seen:
References