Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subject-full-stop false positive #132

Open
knocte opened this issue Jul 27, 2023 · 5 comments
Open

subject-full-stop false positive #132

knocte opened this issue Jul 27, 2023 · 5 comments

Comments

@knocte
Copy link
Member

knocte commented Jul 27, 2023

When title ends with ... then subject-full-stop fails. We should probably fix this in commitlint (upstream).

@knocte
Copy link
Member Author

knocte commented Jul 27, 2023

@tehraninasab
Copy link
Contributor

What should be the logic? accepting 3 dots at the end of commit title?

@knocte
Copy link
Member Author

knocte commented Aug 1, 2023

I think that subject-full-stop should only fail if last character is a dot, but if previous-to-last character is not a dot.

@tehraninasab
Copy link
Contributor

What should be the rule's behavior if its config was set to 'always' use a dot at the end of the title instead of never?

@knocte
Copy link
Member Author

knocte commented Aug 15, 2023

If the title ends with "...", commitlint's subect-full-stop rule should never fail, regardless if it's 'always' or 'never'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants