From 82f1f64954acd041b8dae1ed027a628273fab1de Mon Sep 17 00:00:00 2001 From: "Andres G. Aragoneses" Date: Mon, 5 Feb 2024 12:02:43 +0800 Subject: [PATCH 1/5] CI: move from dotnet7 to dotnet8 The Directory.Build.targets old workaround is removed as well because it's not needed in dotnet8 anymore. --- .github/workflows/CI.yml | 5 +++-- Directory.Build.targets | 16 ---------------- 2 files changed, 3 insertions(+), 18 deletions(-) delete mode 100644 Directory.Build.targets diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml index 35e4d51..081ef2f 100644 --- a/.github/workflows/CI.yml +++ b/.github/workflows/CI.yml @@ -9,7 +9,8 @@ jobs: name: Build and Run Tests runs-on: ubuntu-22.04 container: - image: "ubuntu:22.04" + # TODO: move to 24.04 as soon as it is published in Apr2024 + image: "ubuntu:23.10" steps: - uses: actions/checkout@v2 - name: Install required dependencies @@ -29,7 +30,7 @@ jobs: # The remote certificate is invalid because of errors in the certificate chain: UntrustedRoot apt install --yes --no-install-recommends ca-certificates - apt install --yes --no-install-recommends dotnet7 + apt install --yes --no-install-recommends dotnet8 - name: Restore nuget dependencies run: dotnet restore diff --git a/Directory.Build.targets b/Directory.Build.targets deleted file mode 100644 index 96627be..0000000 --- a/Directory.Build.targets +++ /dev/null @@ -1,16 +0,0 @@ - - - - - - From cf7daf5b67769926941b5b3d7a14691e99037ba6 Mon Sep 17 00:00:00 2001 From: "Andres G. Aragoneses" Date: Mon, 5 Feb 2024 11:46:26 +0800 Subject: [PATCH 2/5] FX.Tests: add FSharp.Core ref to fix build To try to fix this build error: ``` /__w/FX/FX/src/FX.Tests/LimitOrders.cs(5,17): error CS0234: The type or namespace name 'FSharp' does not exist in the namespace 'Microsoft' (are you missing an assembly reference?) [/__w/FX/FX/src/FX.Tests/FX.Tests.csproj] /__w/FX/FX/src/FX.Tests/LimitOrders.cs(16,25): error CS0246: The type or namespace name 'FSharpOption<>' could not be found (are you missing a using directive or an assembly reference?) [/__w/FX/FX/src/FX.Tests/FX.Tests.csproj] 7 Warning(s) 2 Error(s) ``` --- src/FX.Tests/FX.Tests.csproj | 1 + 1 file changed, 1 insertion(+) diff --git a/src/FX.Tests/FX.Tests.csproj b/src/FX.Tests/FX.Tests.csproj index a2c40ae..c2f3d50 100644 --- a/src/FX.Tests/FX.Tests.csproj +++ b/src/FX.Tests/FX.Tests.csproj @@ -10,6 +10,7 @@ + From a4ee0e99ae348f3559eef932198a816261869ed0 Mon Sep 17 00:00:00 2001 From: "Andres G. Aragoneses" Date: Mon, 5 Feb 2024 11:51:15 +0800 Subject: [PATCH 3/5] FX.Tests: add version to FSharp.Core ref to fix restore To try to fix this restore error: ``` /__w/FX/FX/src/FX.Tests/FX.Tests.csproj : error NU1010: The PackageReference items FSharp.Core do not have corresponding PackageVersion. [/__w/FX/FX/FX.sln] Failed to restore /__w/FX/FX/src/FX.Tests/FX.Tests.csproj (in 451 ms). ``` --- src/FX.Tests/FX.Tests.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/FX.Tests/FX.Tests.csproj b/src/FX.Tests/FX.Tests.csproj index c2f3d50..02b2a55 100644 --- a/src/FX.Tests/FX.Tests.csproj +++ b/src/FX.Tests/FX.Tests.csproj @@ -10,7 +10,7 @@ - + From 1496cdc26e1200984f6e734b7cd956367aabb3db Mon Sep 17 00:00:00 2001 From: "Andres G. Aragoneses" Date: Mon, 5 Feb 2024 11:55:13 +0800 Subject: [PATCH 4/5] Directory.Packages.props,FX.Tests: move version attrib out of proj In order to fix this restore error: ``` /__w/FX/FX/src/FX.Tests/FX.Tests.csproj : error NU1008: Projects that use central package version management should not define the version on the PackageReference items but on the PackageVersion items: FSharp.Core. [/__w/FX/FX/FX.sln] ``` --- Directory.Packages.props | 1 + src/FX.Tests/FX.Tests.csproj | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/Directory.Packages.props b/Directory.Packages.props index 1efa6fd..e51e66d 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -13,5 +13,6 @@ + diff --git a/src/FX.Tests/FX.Tests.csproj b/src/FX.Tests/FX.Tests.csproj index 02b2a55..c2f3d50 100644 --- a/src/FX.Tests/FX.Tests.csproj +++ b/src/FX.Tests/FX.Tests.csproj @@ -10,7 +10,7 @@ - + From 0205671692db688ff309b504ecef4f7a517cf2ea Mon Sep 17 00:00:00 2001 From: "Andres G. Aragoneses" Date: Mon, 5 Feb 2024 11:59:05 +0800 Subject: [PATCH 5/5] FX.Tests: move from net7.0 to net8.0 To fix this error when trying to run the tests: ``` Starting test execution, please wait... A total of 1 test files matched the specified pattern. Testhost process for source(s) '/__w/FX/FX/src/FX.Tests/bin/Debug/net7.0/FX.Tests.dll' exited with error: You must install or update .NET to run this application. App: /__w/FX/FX/src/FX.Tests/bin/Debug/net7.0/testhost.dll Architecture: x64 Framework: 'Microsoft.NETCore.App', version '7.0.0' (x64) .NET location: /usr/lib/dotnet/ The following frameworks were found: 8.0.1 at [/usr/lib/dotnet/shared/Microsoft.NETCore.App] Learn more: https://aka.ms/dotnet/app-launch-failed To install missing framework, download: https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=7.0.0&arch=x64&rid=ubuntu.23.10-x64&os=ubuntu.23.10 . Please check the diagnostic logs for more information. Test Run Aborted. ``` --- src/FX.Tests/FX.Tests.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/FX.Tests/FX.Tests.csproj b/src/FX.Tests/FX.Tests.csproj index c2f3d50..7bef3f5 100644 --- a/src/FX.Tests/FX.Tests.csproj +++ b/src/FX.Tests/FX.Tests.csproj @@ -1,7 +1,7 @@ - net7.0 + net8.0