-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
read_swc: strange behaviour when file path contains typo #91
Comments
It's not impossible to have paths with newlines or which look like URLs, but they're pretty rare. As an aside, as there are lots of failure modes for this very general function, maybe it's worth some bespoke errors replacing some of the ValueErrors? |
I fully agree. That said: the My suggested solution would still correctly check most file paths which is an improvement over what's there right now. I'm tempted to add this and see if I can add some more useful error messages (e.g. for malformed SWC files). |
navis.read_swc
will throw very unhelpfulValueErrors
(via pandas) when the input is a non-existing (file)path (e.g. in case of a typo). Try for example this:The reason being that strings are first tested for being folder and files, and failing that will be treated as SWC strings without any additional checks and balances.
I had a look at both
BaseReader
andSwcReader
, and the easiest way, I think, to catch these would be add a quick check right at the start ofnavis.read_swc
(beforeSwcReader.read_any
is called). Something like this:Now this seems to work reasonable well but I'm worried that there is some corner case I'm not thinking about. Thoughts @clbarnes ?
The text was updated successfully, but these errors were encountered: