Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x axis tick's height not calculated correctly #3643

Closed
netil opened this issue Feb 13, 2024 · 1 comment
Closed

x axis tick's height not calculated correctly #3643

netil opened this issue Feb 13, 2024 · 1 comment
Assignees
Labels

Comments

@netil
Copy link
Member

netil commented Feb 13, 2024

Description

master expected
image image

Side effect caused by #3585
@michkami can you check the issue?

Steps to check or reproduce

@netil netil added the bug label Feb 13, 2024
@netil netil self-assigned this Feb 14, 2024
@netil
Copy link
Member Author

netil commented Feb 14, 2024

it happens when x axis tick given negative rotate value with multiline=false option.

axis: {
	x: {
		type: "category",
		tick: {
			rotate: -60,
			multiline: false,
		}
	}
}

netil pushed a commit to netil/billboard.js that referenced this issue Feb 14, 2024
Update condition determining x Axis tick is rotated to consider
absolute number(weather positive or negative) value.

Ref naver#3643
@netil netil closed this as completed in ac26f11 Feb 14, 2024
github-actions bot pushed a commit that referenced this issue Feb 15, 2024
# [3.11.0](3.10.3...3.11.0) (2024-02-15)

### Bug Fixes

* **Axis:** Correct x axis height calculation for autorotated x axis tick texts ([d5b5d09](d5b5d09)), closes [#3584](#3584) [#3585](#3585)
* **axis:** Fix x Axis tick height calculation ([ac26f11](ac26f11)), closes [#3643](#3643)
* **axis:** Fixed x axis tick texts rotation when legend is positioned right ([ed4703e](ed4703e)), closes [#3570](#3570) [#3571](#3571)
* **packages:** Fix build error with moduleResolution:bundler ([9c17eea](9c17eea)), closes [#3541](#3541)
* **radar:** Fix axes texts exclusion on resize ([3a814a5](3a814a5)), closes [#3126](#3126)
* **regions:** Fix applying regions class ([7e4fa71](7e4fa71)), closes [#3611](#3611)
* **tooltip:** Fix tooltip position from interference ([9d28cbb](9d28cbb)), closes [#3575](#3575)
* **tooltip:** Fix wrong tooltip selection on browser scroll change ([#3593](#3593)) ([8f80637](8f80637)), closes [#3592](#3592)
* **zoom:** Fix zoom state on data load ([967207b](967207b)), closes [#3422](#3422)

### Features

* **arc:** Intent to ship arc.rangeText ([e887baf](e887baf)), closes [#2120](#2120)
* **axis:** Add x.tick.text.inner option ([cfc856c](cfc856c)), closes [#3552](#3552)
* **gauge:** Intent to ship gauge.enforceMinMax ([c277201](c277201)), closes [#2125](#2125)
* **gauge:** Intent to ship gauge.label.ratio ([d4e49ba](d4e49ba)), closes [#3633](#3633)
* **legend:** Itent to ship legend.format, legend.tooltip ([aecff2f](aecff2f)), closes [#3533](#3533)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant