Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve transaction review when interacting with contracts #230

Open
arobsn opened this issue Dec 6, 2024 · 0 comments
Open

Improve transaction review when interacting with contracts #230

arobsn opened this issue Dec 6, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@arobsn
Copy link
Member

arobsn commented Dec 6, 2024

From TG:

When signing a tx which has a p2s input and p2s output (same address) any assets in this address are shown as being sent to this address in the tx overview (not leaving wallet but shows as being sent). This can confuse users as it might be large amounts that they dont expect
IMAGE 2024-12-06 16:16:39

We probably need a major refactoring of the TransactionInterpreter class to do a full analysis and try to determine how inputs are related to outputs and display it more assertively to the user.

@arobsn arobsn added the enhancement New feature or request label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant