Add environment option for secure local website #3532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the purpose here? |
|
@G-Ambatte Is it ok if we close this one for now and bring it back to its own issue where the need for this can be discussed? |
That's a good idea, I don't think the implementation is novel enough to warrant holding on to the PR. |
|
Closing per last exchange. |
G-Ambatte
commented
Nov 20, 2024
| let webServer = http.createServer(server.app); | ||
|
|
||
| const NODE_ENV = config.get('node_env'); | ||
| if(NODE_ENV === 'local.secure') { |
There was a problem hiding this comment.
If we change this line to a file existence check, rather than checking for a specific NODE_ENV type, then that should simplify this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the NODE_ENV environment variable to be set to
local.secure. This option, when combined with ahostnameconfiguration item, creates a webserver that serves pages secured with certificates configured for thehostname.At this point in time, this is completely experimental and only of limited use in local installations. It has NOT been thoroughly tested, so some Homebrewery features may not work correctly with this environment setting.
This PR resolves #3900.