-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store toolbar state in localStorage #3835
Comments
How many different brew ids should be in there? |
Why not just a universal setting instead of per brew? |
I was thinking you may want to see a different zoom and page layout depending on the brew, but perhaps you're right, one universal setting is good enough. |
How about this: save the current setting in localStorage, not as brew specific. But if a new (not just So this means that if you hit |
This restriction sounds like it defeats the purpose of the PR if it disappears every time you change pages. How often are users just hitting reload on the same page without visiting another brew in between? |
I agree |
Both visibility and zoom state should be saved in localstorage with the id of the brew, to guarrantee a better UX, if a user does not want to have the toolbar there all the time, it should stay hidden between reloads, and same goes for the zoom level.
The text was updated successfully, but these errors were encountered: