You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I found this accidentally while fixing a toolbar issue.
We define the page height arbitrarily in brewRenderer to use to calculate scrolls and stuff. I know the function still works, but i assume this code could be cleaner.
In addition, this code calculates the height to establish in the brewRenderer element:
However, A height of 100vh, works just fine, given other adjustments that make sense to have the toolbar there.
I preferred to make an issue for this rather than cluttering the gitter chat.
The text was updated successfully, but these errors were encountered:
I found this accidentally while fixing a toolbar issue.
We define the page height arbitrarily in brewRenderer to use to calculate scrolls and stuff. I know the function still works, but i assume this code could be cleaner.
In addition, this code calculates the height to establish in the brewRenderer element:
However, A height of 100vh, works just fine, given other adjustments that make sense to have the toolbar there.
I preferred to make an issue for this rather than cluttering the gitter chat.
The text was updated successfully, but these errors were encountered: