-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added some latin accents #3646
Added some latin accents #3646
Conversation
Finally my character Ágata will have their name correctly displayed |
Can we get a reproduction brew, or source code for one? Sorry, I don't know how to create those characters on my keyboard. |
@G-Ambatte here you have:
Is this what you asked for? |
Actually, please test with this:
We don't need them all to exist, but |
Ohh didn't think about the Ñ. I'll add it. Also the Ü |
Please show all the characters i sent |
Sent out a test deployment for this https://homebrewery-pr-3646.herokuapp.com/. Should help for getting a side-by-side comparison with longer strings, though from the screenshots it looks ok. @MiniX16 What software did you use to add the missing glyphs, if I might ask? |
Also, | appears to be the glyph for 1 for some reason, but that is not a big issue. I can fix the two characters if it is important, should be easy with Glyphr Studio 2 |
Mmmmm.... letter alignment and spacings appear to have been corrupted with this change. Especially noticeable on lowercase j. This will need to be redone. See this video where I swap between the live version and the PR deployment. Recording.2024-08-20.174055.mp4 |
It's different from the actual 1; might actually be a lowercase L? Might as well change it if we are remaking the font anyway. Our font is based in Mrs Eaves, which does use just a straight line. |
I used birdFont (didn't find a different one free).
Offf... didn't realized about that. I can try to redo it with Glyphr Studio 2 as @5e-Cleric said. EDIT: Also tried FontForge but not working idk why. |
If you feel like it is problematic, i can jump in. |
I'll do one last try and if I don't succeed it's yours. Never thought that modifying a font could be that messy. |
Oops when deleting the branch, the PR closed, didn't thought that would happen. Anyways, I tried again with Glyphr Studio 2 and same problem, (even worse) so maybe @5e-Cleric you can take it from here hehe. |
Hm, not sure how could that happen, i'll try. |
Simply changing the format to |
Yeah that's what a thougth, also all woff2 editors are not free. I've only found FontForge if you want to try but when I was trying for no reason when modifying one "A" (for example) all "A" were modified. |
I just tried doing it with FontForge (since a random guy at reddit told me how to fix my last problem with FontForge and finally modify only one glyph at the same time) but same problem. Here there wasn't any conversion, the file started as |
This PR resolves #3638.
Added some latin accents to the
Mr Eaves Small Caps
font. Here the comparison, before:And after: