Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto convert CRLF and LF for uploaded code and tests #87

Open
minhnhatnoe opened this issue May 16, 2023 · 3 comments
Open

Auto convert CRLF and LF for uploaded code and tests #87

minhnhatnoe opened this issue May 16, 2023 · 3 comments
Labels
cat:admin Related to the admin panel cat:user Related to the User UI enhancement New feature or request go Pull requests that update Go code priority:medium Medium priority: Mostly for next minor
Milestone
v0.9.0 ???

Comments

@minhnhatnoe
Copy link
Contributor

Is your feature request related to a problem? Please describe.

In many cases, code and testcases are sent from a Windows client to a Linux judging server, possibly creating compatibility issues.

Describe the solution you'd like

The judging server should be able to detect it's host OS, then convert all text files received to the respective format.

Additional context

Should we implement some type of distributed judging, all workers should be able to detect the OS type and convert files independently.
@minhnhatnoe minhnhatnoe added the enhancement New feature or request label May 16, 2023
@natsukagami natsukagami changed the title Auto convert CRLF and LF Auto convert CRLF and LF for uploaded code and tests May 16, 2023
@natsukagami natsukagami added cat:admin Related to the admin panel cat:user Related to the User UI priority:medium Medium priority: Mostly for next minor go Pull requests that update Go code labels May 16, 2023
@natsukagami
Copy link
Owner

Hmm, I wonder when this will cause a problem?

@minhnhatnoe
Copy link
Contributor Author

minhnhatnoe commented May 18, 2023 •
edited
Loading

I haven't had the time to fiddle around, but I believe that using CRLF in .sh files renders the she-bang invalid.

@natsukagami natsukagami added this to the v0.8.0 "Kirifu Megumi" milestone May 29, 2023
@minhnhatnoe
Copy link
Contributor Author

Pull Request #103 solves this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cat:admin Related to the admin panel cat:user Related to the User UI enhancement New feature or request go Pull requests that update Go code priority:medium Medium priority: Mostly for next minor
Projects
None yet
Milestone
v0.9.0 ???
Development

No branches or pull requests
2 participants
@natsukagami @minhnhatnoe