-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add kv::keys with filters #1280
Labels
Comments
Jarema
added
good first issue
Good for newcomers
accepted
The defect or proposal as been accepted
help wanted
labels
Jun 20, 2024
Can I try to work on this? I'm a noobie on rust though! |
Sure, go ahead! |
are unit test working? I tried to run running 1 test
test kv::keys ... FAILED
failures:
---- kv::keys stdout ----
thread 'kv::keys' panicked at nats-server/src/lib.rs:268:29:
called `Result::unwrap()` on an `Err` value: Os { code: 2, kind: NotFound, message: "No such file or directory" }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
kv::keys
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 19 filtered out; finished in 0.01s
error: test failed, to rerun pass `-p async-nats --test kv_tests` EDIT: Sorry, I got where the error comes from. |
As we updated the ADR to have just one method, please re-check the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Proposed change
Add two new methods:
keys_with_fitlters
require a feature flagserver_2_10
. That is also the reason why they are separated, instead of one method taking interator of sorts.https://github.com/nats-io/nats-architecture-and-design/blob/main/adr/ADR-8.md?plain=1#L139
Reference ADR issue: nats-io/nats-architecture-and-design#289
Use case
nats-io/nats-architecture-and-design#289
Contribution
No response
The text was updated successfully, but these errors were encountered: